Add Glif public Filecoin RPC listing - #3149
Conversation
Summary
Errors per inputErrors in ./listings/specific-networks/filecoin/apis.csv
|
USS-Supervisor
left a comment
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The CSV structure and new offer reference look sound, but the current-cycle link-check report found a broken URL in the newly added Filecoin listing action button.
Findings:
- MEDIUM
listings/specific-networks/filecoin/apis.csv:45- The new[Send requests](https://api.node.glif.io/rpc/v1)action link returns 404 under the reviewer-owned link-check run32629837745(Errors: 1,[404] <https://api.node.glif.io/rpc/v1>). Since action buttons are clickable links, please replace this with a browser-valid Glif/Filecoin docs or service URL, or remove the action button and keep the RPC endpoint represented somewhere that is not link-checked as a normal web URL.
Confidence: HIGH
eugene17kotov
left a comment
eugene17kotov
left a comment
There was a problem hiding this comment.
Thanks for adding the Filecoin public RPC endpoint. The endpoint itself is valid, but it should not be modeled as a new Glif offer.
The current service is provided and operated through Chain.Love RPC. filecoin.chain.love is the current Filecoin RPC service, and Chain.Love already exists as the API provider in the database. The remaining glif.io endpoints represent the underlying/legacy Glif infrastructure rather than the current provider identity.
USS-Supervisor
left a comment
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The original Glif link/modeling issue is addressed and the CSV still parses cleanly, but the current head adds a new Chain.Love Filecoin API listing with a chain/slug mismatch. Required validation is green, but the current-head link-check is SKIPPED, so this is not approvable yet either.
Findings:
- MEDIUM
listings/specific-networks/filecoin/apis.csv:19- The new row slug ischain-love-full-archive-calibnet-pay-as-you-go, but itschaincolumn ismainnet. That puts a calibnet-named listing into Filecoin mainnet output and leaves two mainnet full-archive/pay-as-you-go-looking Chain.Love rows with different prices. Please either set this row'schaintocalibnetif it is the calibnet offer, or rename/rework the row so the slug and chain describe the same network.
Confidence: HIGH
Summary
|
USS-Supervisor
left a comment
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The previous Glif/modeling issue and the calibnet/mainnet chain mismatch are resolved. The current head is a focused update to Chain.Love Filecoin API pricing/listing rows, with stable CSV structure, resolving offer references, no duplicate slugs, existing chain logos, green validation, and a clean current-cycle link-check.
Findings: None.
Confidence: HIGH
3 participants
Summary
Adds Glif Nodes as a public Filecoin mainnet RPC offer and listing.
Type of change
Scope
Filecoin.ChainHeadJSON-RPC request during preparation.Links
Validation checklist
!providersyntax, and that entities in/networkssub-folders inherits records from/providersfolder.Verification note
This contribution was prepared with agent assistance. The source documentation and endpoint response were checked programmatically; the human-attestation checkboxes above are intentionally left unchecked rather than making an inaccurate personal declaration.
Optional
0x9FBDcd966fCd54382277a33b185c970Fba22B28E